Add old-style rendering option to progress bars #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Progress indicators now use the notification API. (#1160) | ||
| * Progress indicators can now either use the new notification API, using | ||
| `style="notification"`, or be displayed with the previous styling, using' | ||
| `style="old"`. (#1160, #1327, #1329) |
There was a problem hiding this comment.
Should be moved to "breaking changes" section and reworded to make clear that the default behavior is the new style. And probably specifically call out that if you have custom CSS for the old styling then you'll need to use old to not get broken UI.
There was a problem hiding this comment.
I can take care of that, since I'm working on NEWS. You can just undo the change to NEWS, @wch if you want (or we can work it out later because there will be a merge conflict otherwise).
There was a problem hiding this comment.
I'll take care of it here, since it makes sense to put it in this PR. I'll probably need to add something about it to the release notes after it's merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1327. This adds an argument,
style, towithProgressandProgress$new, which lets the user choose new notification-based progress bars with"notification"(the default), or the older style progress bars with"old".This is so that users who have custom-styled their progress bars with CSS can keep that CSS. It will require them to add the
style="old"argument, however.We had also discussed adding a "raw" option where the progress bars would get CSS classes but we wouldn't actually have any CSS that styles the bars. I think it would be better to wait on that until the next version of Shiny.