Add shiny:filedownload Javascript event #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
commented
Jan 31, 2017
| // Trigger shiny:filedownload event whenever a downloadButton/Link is clicked | ||
| $(document).on('click.shinyDownloadLink', 'a.shiny-download-link', function(e) { | ||
| var evt = jQuery.Event('shiny:filedownload'); | ||
| evt.name = this.id; |
There was a problem hiding this comment.
Should set evt.href here.
wch
commented
Jan 31, 2017
R/shinywrappers.R
Outdated
| #' @inheritParams markRenderFunction | ||
| #' @param snapshotExclude If TRUE, exclude the output from test snapshots. | ||
| #' | ||
| #' @export |
There was a problem hiding this comment.
Don't export, and make snapshotExclude() a wrapper function.
wch
force-pushed
the
wch/download-event
branch
from
500eb72
to
67c599f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things that are needed for testing file downloads:
shiny:filedownloadevent in Javascript. The event object contains the ID of the downloadButton/Link. It does not contain the href, because it changes each time the application is run (if the ID isdownloadData, the link looks something likesession/4b3259d8737d682d272e02ecc3faba5e/download/downloadData?w=).markOutputAttrs, which can be used to mark the object returned from a render function (which is a reactive) with an attribute. When the reactive is assigned to an output value, the attribute will be copied to the corresponding observer.downloadHandlersso that their values are not snapshotted. As mentioned above, the value -- the href -- changes with each run of the application, so it doesn't make sense to snapshot it for testing.