Add a function to test if the app is running #1785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
added a commit
that referenced
this pull request
Jul 11, 2017
Squashed commit of the following:
commit 8667bed8962069a5cab8691f981e2b7ba9d449c3
Author: Winston Chang <winston@stdout.org>
Date: Tue Jul 11 14:36:11 2017 -0500
Edits
commit c4e8549
Author: Konrad Rudolph <konrad.rudolph@gmail.com>
Date: Fri Jul 7 17:57:33 2017 +0100
Describe changes
commit 7b05c2e
Author: Konrad Rudolph <konrad.rudolph@gmail.com>
Date: Fri Jul 7 17:54:40 2017 +0100
Add new function to doc index
commit eb93ebf
Author: Konrad Rudolph <konrad.rudolph@gmail.com>
Date: Fri Jul 7 17:54:30 2017 +0100
Add documentatio for new function
commit 1a6c8a4
Author: Konrad Rudolph <konrad.rudolph@gmail.com>
Date: Fri Jul 7 17:53:13 2017 +0100
Add a function to test whether the app is running
|
Thanks! I made some edits and squash-merged in 4cb428b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago I asked how to test whether Shiny is running. I found a preliminary solution but there are cases where it breaks. The solution is also generally quite hacky and brittle.
I noticed that adding this functionality to Shiny should be trivial; the actual implementation is a single line of code that just inspects
.global$running. I therefore hope that this PR is straightforward.I didn’t add a unit test since it feels that an integration test would be more appropriate, and I couldn’t find any other unit tests for runtime Shiny behaviour in the code base. I did run
devtools::check()to verify that the change didn’t break anything obvious. I also added documentation, filled theNEWS.md, and signed the contributor agreement.