Fix #2000: Implicit calls to xxxOutput not working inside modules #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
force-pushed
the
joe/bugfix/implicit-output-ns
branch
from
3d57a9a
to
1a4057a
Compare
|
@jcheng5 I would prefer it to be added in shiny-examples as I would not go in unit tests to run when doing regression testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just forgot to have the implicit xxxOutput call respect namespaces.
Testing notes: See #2000 for the repro case. That code sample should be pasted into a new .Rmd file and run. With this patch applied, both buttons produce the same effect. Normally I put these repro cases into shiny-examples, but in this case I have a unit test that accomplishes the same thing so I don't think it's necessary. @shalutiwari let me know if you disagree and think we still need the test case to be added to shiny-examples.