Fixes #174, allowing specific days of the week to be disabled. #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ific yyyy-mm-dd format strings
|
I forced push to my master and I'm not 100% that's what made TravicCI mad, but it was coincidental. Happy to adjust, just let me know the best path to resolution. |
wch
reviewed
Aug 6, 2018
R/input-date.R
Outdated
| #' ) | ||
| #' | ||
| #' shinyApp(ui, server = function(input, output) { }) | ||
| #' } | ||
| #' @export | ||
| dateInput <- function(inputId, label, value = NULL, min = NULL, max = NULL, | ||
| format = "yyyy-mm-dd", startview = "month", weekstart = 0, language = "en", | ||
| format = "yyyy-mm-dd", startview = "month", weekstart = 0, | ||
| datesdisabled = NULL, daysofweekdisabled = NULL, language = "en", |
There was a problem hiding this comment.
Can you move these arguments to the end? Even though this is the right place to put them conceptually, there could be existing code out there that is broken by this change.
|
Can you send a CLA, as described in https://github.com/rstudio/shiny/blob/master/CONTRIBUTING.md? |
…l if datesdisabled is Date object
|
CLA sent. Updated argument ordering and added the same conditional formatting for |
jcheng5
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174, with a new parameter
daysofweekdisabledavailable todataInput().An example app:
Original code by Niko Eckerskorn (@kadrach). I made this PR because the original fork was 2 years behind
masterand the issue is still unresolved.