Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken font-awesome icon in shinydashboard #2208

Closed
wch opened this issue Oct 12, 2018 · 5 comments
Closed

Broken font-awesome icon in shinydashboard #2208

wch opened this issue Oct 12, 2018 · 5 comments
Assignees
Milestone

Comments

@wch
Copy link
Collaborator

wch commented Oct 12, 2018

This is from rstudio/shinydashboard#297.

On master and v1.2-rc, the following app has a broken hamburger icon:

library(shiny)
library(shinydashboard)

ui <- dashboardPage(
  dashboardHeader(),
  dashboardSidebar(),
  dashboardBody()
)

server <- function(input, output) { }

shinyApp(ui, server)

image

We should look at this carefully, because it might be a sign that other users of FA icons could have problems

@wch wch added this to the 1.2 milestone Oct 12, 2018
@wch
Copy link
Collaborator Author

wch commented Oct 12, 2018

It turns out this was cause by the non-standard way that shinydashboard used Font Awesome, and was fixed by rstudio/shinydashboard#299.

@wch wch closed this as completed Oct 12, 2018
@ismirsehregal
Copy link
Contributor

ismirsehregal commented Oct 23, 2018

Is this still part of the same issue?:

image

library(shiny)

ui <- fluidPage(
  p(),
  actionButton("Btn", "Btn", icon = icon("creative-commons-sampling", lib = "font-awesome"))
)

server <- function(input, output) {}

shinyApp(ui = ui, server = server)

Using
shiny * 1.1.0.9001 2018-10-15 Github (3cea5fb)

@wch
Copy link
Collaborator Author

wch commented Oct 23, 2018

@ismirsehregal Can you try with Shiny 1.2 RC?

devtools::install_github('rstudio/shiny', 'v1.2-rc')

@ismirsehregal
Copy link
Contributor

ismirsehregal commented Oct 23, 2018

@wch same (broken) output using shiny * 1.2.0 2018-10-23 Github (2629e59)

@ismirsehregal
Copy link
Contributor

Thanks for investigating that fast again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants