Make updateSelectizeInput() work with labels again #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
requested changes
Nov 15, 2018
srcjs/input_binding_select.js
Outdated
| if (typeof(selectize) !== 'undefined') { | ||
| selectize.setValue(value); | ||
| } else $(el).val(value); | ||
| if (this._is_selectize(el)) { |
srcjs/input_binding_select.js
Outdated
| if (data.hasOwnProperty('label')) | ||
| $(el).parent().parent().find('label[for="' + $escape(el.id) + '"]').text(data.label); | ||
| if (data.hasOwnProperty('label')) { | ||
| let label_name = $escape(el.id); |
There was a problem hiding this comment.
Better variable for label_name would be escaped_id
srcjs/input_binding_select.js
Outdated
| // Return true if it's a selectize input, false if it's a regular select input. | ||
| _is_selectize: function(el) { | ||
| var config = $(el).parent().find('script[data-for="' + $escape(el.id) + '"]'); | ||
| if (config.length === 0) { |
There was a problem hiding this comment.
This could be simplified to return config.length > 0;
wch
force-pushed
the
fix-selectize-label
branch
from
d05679d
to
775d528
Compare
|
I've made the changes, and have a new test app which exercises the library(shiny)
ui <- fluidPage(
actionButton('update','Update selectize inputs'),
selectInput("select", "Original label (selectInput)", choices=c("A", "B", "C"), selectize = FALSE),
selectizeInput("selectize", "Original label (selectizeInput)", choices=c("A", "B", "C"))
)
server <- function(input, output,session) {
observeEvent(input$update,{
# Set the choices and selected value in two separate steps to test the
# setValue code path.
updateSelectInput(session, "select", label="New label (selectInput)",
choices = c("D", "E", "F"))
updateSelectInput(session, "select", selected = "E")
updateSelectizeInput(session, "selectize", label="New label (selectizeInput)",
choices = c("X", "Y", "Z"))
updateSelectInput(session, "selectize", selected = "Y")
})
}
shinyApp(ui = ui, server = server) |
jcheng5
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2245.
Test application: