New target for shiny:inputchanged event
#2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR, and for updating the NEWS 👍 I'm not sure I'd categorize the previous behavior as a bug though; how do you feel about listing it under improvements instead? |
|
I wasn't certain either and jumped the gun. I'll move the item under Improvements. |
|
Cool, thanks for switching that up. I noticed also that you don't appear to have sent in a contributor agreement. If you have, I could be missing something, so please don't hesitate to email me at alan@rstudio.com and we can figure it out. |
|
I sent along the agreement and have moved the news item under improvements. |
|
CA received ✉️ ✅ |
wch
approved these changes
May 29, 2019
alandipert
added a commit
to rstudio/shiny-examples
that referenced
this pull request
May 30, 2019
alandipert
added a commit
to rstudio/shiny-examples
that referenced
this pull request
May 31, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #2442 the JavaScript Events in Shiny article will need to be updated. Specifically the line below, replacing "document" with "input element".