fix(downloadButton): Return tag directly #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rstudio#2392 The downloadButton has a very simple longstanding issue where it does not return the tag explicitly. This is only an issue depending on how the function is called. For example: `tag <- downloadButton(...)` has always worked fine, as has `anotherFunction(downloadButton(...))`. It is likely this issue does not show in the normal shiny app because it uses one of these methods. However `downloadButton(...)` didn't not work correctly, which means rmarkdown documents didn't show the downloadButton correctly.
|
|
fennovj
changed the title
downloadButton() not rendering in rmarkdown documentsdownloadButton() not rendering in rmarkdown documents, fxes #2392
#Conflicts: # R/bootstrap.R
gadenbuie
changed the title
downloadButton() not rendering in rmarkdown documents, fxes #2392
LiNk-NY
approved these changes
Jan 29, 2024
|
Thanks @fennovj ! It looks like you'd need to sign the CLA |
LiNk-NY
approved these changes
Jan 30, 2024
cpsievert
approved these changes
Jan 30, 2024
|
Thank you @fennovj for the contribution and for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2392
The
downloadButton()has a very simple longstanding issue where it does not return the tag explicitly.It is likely this issue does not show in the normal shiny app because it uses a different method to capture the output, such as
tag <- downloadButton(...)However directly calling
downloadButton(...)didn't not work correctly, which means rmarkdown documents didn't show the downloadButton correctly.Minimal code example: Without the fix, only the first downloadbutton is shown. With the fix, both download buttons are shown.