Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IE8 and IE9 file upload support #3075

Merged
merged 5 commits into from Sep 28, 2020
Merged

Remove IE8 and IE9 file upload support #3075

merged 5 commits into from Sep 28, 2020

Conversation

wch
Copy link
Collaborator

@wch wch commented Sep 23, 2020

Closes #3074.

@wch wch requested a review from schloerke September 23, 2020 19:02
@wch wch requested a review from jcheng5 September 24, 2020 15:49
schloerke
schloerke reviewed Sep 28, 2020
View reviewed changes
R/shiny.R Show resolved Hide resolved
schloerke
schloerke approved these changes Sep 28, 2020
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending no work needed for $saveFileUrl()

@wch wch merged commit f9a94d9 into master Sep 28, 2020
@wch wch deleted the wch-rm-ie-upload branch September 28, 2020 21:03
@daattali daattali mentioned this pull request Oct 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

@jcheng5 jcheng5 Awaiting requested review from jcheng5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the support for IE8/9 in fileInput()?
2 participants
@wch @schloerke