htmlOutput: allow custom container function #704
Conversation
| htmlOutput <- function(outputId, inline = FALSE) { | ||
| container <- if (inline) span else div | ||
| container(id = outputId, class="shiny-html-output") | ||
| htmlOutput <- function(outputId, inline = FALSE, |
There was a problem hiding this comment.
If we really wanted to have the arguments be id, container, inline (both for consistency and because we think container is more likely?) then we could just do that and treat container=TRUE as container=span and container=FALSE as container=div.
I'm also 100% fine with taking this PR as-is. This suggestion is just in case it bothers you that the order is different.
There was a problem hiding this comment.
Should it be a warning if you pass unnamed arguments to ...? (meaning contents that will be wiped out when a value is rendered)
I could see people using that to display loading messages. I'm not sure if that's how we want to solve that problem though.
|
Good idea with checking for unnamed args in |
htmlOutput: allow custom container function
This PR allows using a custom container for
uiOutput, instead of justdivorspan. It also allows adding custom classes to the container.This is for rstudio/shinydashboard#1.