Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plot interactions with ggplot2 #802

Merged
merged 61 commits into from May 1, 2015
Merged

Add plot interactions with ggplot2 #802

merged 61 commits into from May 1, 2015

Conversation

wch
Copy link
Collaborator

@wch wch commented Apr 16, 2015 •
edited by bborgesr

This adds plot interactions with plots generated by ggplot2, including facets. Also:

  • Brushing is scale-aware in base and ggplot graphics. This means that if you send an updated plot with new bounds, the brush can change is pixel coordinates to preserve the same data coordinates.
  • Brushes can now be resized.
  • I moved renderPlot() out of shinywrappers.R into its own file, render-plot.R. It might be a good idea to move other render functions to their own files as well, but that can be done in a separate PR.

Demo at: https://winston.shinyapps.io/interactive_graphic

wch added 29 commits April 16, 2015 23:40
@wch
Move renderPlot into separate file
a9a6e96
@wch
Use separate function for getting coordmap
3f8cc71
@wch
Rename coordmap usr and bounds to domain and range
667bc95
@wch
Add click/hover/brush support for ggplot2
463ee7e
@wch
Treat minified JS and map files like binary
e7f2572
@wch
Add support for ggplot2 reversed scales
1dc061e
@wch
Add support for ggplot2 log scales
3584166
@wch
Add support for ggplot2 log coord transforms
6c65b1f
@wch
Safe handling of discrete scales
2e6347b
@wch
Better function name
dbadc05
@wch
Consolidate coordinate functions
2994340
@wch
Encode facet information
04768ad
@wch
Partial refactoring of brush
03784ba
@wch
Modularize brush code
dbcdbda
@wch
Put shiftToRange in right place
2c121dc
@wch
Fix bottom/top reversal
abb722f
@wch
Implement client-side support for facets
fbf1ba1
@wch
Gruntfile: add watch support for concat
55cbd72
@wch
Fix height/width calculation of brush div
d925702
@wch
Partial implementation of scale/inv
48cd720
@wch
Add functions to coordmap object
0b3c2e1
@wch
Fix log scaling
4d074c6
@wch
Restore brush even when scales change
e9f78f6
@wch
Get correct coordinates for panels
4e80e35
@wch
Move clipToBounds from coordmap to panel
7cfaa2a
@wch
Cleaner coordmap initialization
21e9ffe
@wch
Use 'expand' parameter
ffb1b06
@wch
Fix brush import for reverse scales
7b17ce5
@wch
Send brush data when reset
e9cd1be
@wch wch force-pushed the interact-ggplot branch 2 times, most recently from 60fdd9c to aabad3d Compare April 29, 2015 21:27
@wch
Copy link
Collaborator Author

wch commented Apr 29, 2015

I think this PR should be ready to merge now.

@jcheng5
Copy link
Member

jcheng5 commented Apr 30, 2015

Nice. I'll review tomorrow.

@wch
Copy link
Collaborator Author

wch commented May 1, 2015

I've addressed the issues we discussed, so this should be ready to merge.

jcheng5 added a commit that referenced this pull request May 1, 2015
@jcheng5
Merge pull request #802 from rstudio/interact-ggplot
1136ad0 
BOOM!!!!
@jcheng5 jcheng5 merged commit 1136ad0 into master May 1, 2015
@jcheng5 jcheng5 deleted the interact-ggplot branch May 1, 2015 16:51
@jcheng5
Copy link
Member

jcheng5 commented May 1, 2015

Congratulations! 👏

Can you update NEWS on master? I bumped the version already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wch @josiekre @jcheng5