Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update request] The default icon for menuSubItem() "angle-double-right" is now "angles-right" in Font Awesome 6.0.0 #389

Closed
anna-doizy opened this issue Aug 2, 2022 · 5 comments

Comments

@anna-doizy
Copy link

Font Awesome is now 6.0.0 and some names have changed. Especially the one for the icon that is used by default in the menuSubItem function: https://origin.fontawesome.com/icons/angles-right

Would you please update the default icon name in:

menuSubItem(text, tabName = NULL, href = NULL, newtab = TRUE,
  icon = shiny::icon("angle-double-right"), selected = NULL)

Because it leads to this issue : https://stackoverflow.com/questions/32686195/shinydashboard-some-font-awesome-icons-not-working

Thank you!

@ismirsehregal
Copy link

Please see my PR here: #388

@anna-doizy
Copy link
Author

Great! Sorry, I didn't see your PR.

@ismirsehregal
Copy link

This was just FYI - I wouldn't close the issue until it is resolved in the main branch.

@anna-doizy anna-doizy reopened this Aug 16, 2022
@YongbingDing
Copy link

YongbingDing commented Oct 11, 2022 via email

@ismirsehregal
Copy link

The latest version of {fontawesome} allows to reference icons by several of their previous names. So I guess this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants