-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sortable and shiny modules are currently incompatible #100
Comments
Ok. So
When these values are set, they are unaware of the Reasoning:
I'm too far removed from the code to remember why I used If the Originally posted by @schloerke in #95 (comment) I had proposed another solution but it does not fully work with modules. I think we need to revisit why we have both If we can at least make it a suffix, then module name spaces ( |
Thank you for investigating and elaborating @schloerke 🙏
This seems like the key question, I was guessing that perhaps there was some reason related to how SortableJS works, but I'm not familiar enough with the library to know. I assume this is something that needs input from the other devs working on sortable and I should standby before working on a PR? |
Hey @andrie & @schloerke,
I've spent a handful of hours trying to figure out what's going on here and it looks like the issue goes beyond just the update module, it appears that the handling of the shiny input ids in sortable is incompatible with shiny modules.
I've added a contrived example in 5c9f4f7 that can be run with the console open. Clicking either of the buttons does not trigger the input methods.
I'm trying to hunt down the differences in how the
input_id
is handled in this package compared to others, but I'm wondering if anyone has a better understanding of what all needs to change to standardize the handling of theinput_id
argument internally such thatsortable
works in a modularized shiny app?Originally posted by @yogat3ch in #95 (comment)
The text was updated successfully, but these errors were encountered: