Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): remove duplicated dialog role #1463

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Jan 15, 2021

Modal was rendering duplicated role=dialog elements.

image

This PR removes the role on the outer div.

@SevenOutman SevenOutman added the v4 Issues about legacy 4.x version label Jan 15, 2021
@vercel
Copy link

vercel bot commented Jan 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite/hqoy3889d
✅ Preview: https://rsuite-git-fix-v4-dialog-a11y.rsuite.vercel.app

rsuite-next – ./

🔍 Inspect: https://vercel.com/rsuite/rsuite-next/dvh99t3b2
✅ Preview: Canceled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Issues about legacy 4.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants