Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(CheckPicker): infer value and onChange types from data prop #2228

Merged
merged 1 commit into from Dec 17, 2021

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Dec 16, 2021

value and onChange(value) type are now inferred from data item's value property.

@vercel
Copy link

vercel bot commented Dec 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/3BhcdxPV41nBp9zGZPxngzUNebte
✅ Preview: Canceled

rsuite-nextjs – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-nextjs/4JxatDhzbHuNCacBwBDa7gA4G8wV
✅ Preview: https://rsuite-nextjs-git-perf-checkpicker-infer-type-from-data-rsuite.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b2b1fc1:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #2228 (b2b1fc1) into main (e5661fd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2228   +/-   ##
=======================================
  Coverage   85.48%   85.49%           
=======================================
  Files         272      272           
  Lines        8538     8540    +2     
  Branches     2378     2379    +1     
=======================================
+ Hits         7299     7301    +2     
  Misses        669      669           
  Partials      570      570           
Flag Coverage Δ
ChromeCi 85.46% <100.00%> (+<0.01%) ⬆️
Firefox 85.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SelectPicker/SelectPicker.tsx 90.90% <ø> (ø)
src/CheckPicker/CheckPicker.tsx 86.08% <100.00%> (ø)
src/Nav/Nav.tsx 100.00% <0.00%> (ø)
src/Nav/NavContext.ts 100.00% <0.00%> (ø)
src/Dropdown/DropdownToggle.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5661fd...b2b1fc1. Read the comment docs.

@SevenOutman SevenOutman merged commit eb4f9a8 into main Dec 17, 2021
@SevenOutman SevenOutman deleted the perf/CheckPicker-infer-type-from-data branch December 17, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants