Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Picker): add ref to PickerComponentProps #2261

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

MarvelSQ
Copy link
Member

@MarvelSQ MarvelSQ commented Dec 28, 2021

fix PickerProps missing ref

const ref = React.createRef<PickerInstance>();

<SelectPicker ref={ref} data={[]} />

@vercel
Copy link

vercel bot commented Dec 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-nextjs – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-nextjs/7N1gSjb2wNP1zm8AfDz5nVERR2HU
✅ Preview: https://rsuite-nextjs-git-fork-marvelsq-fix-picker-type-rsuite.vercel.app

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/xS3ep6y4b4oYybd8BRQvgQfZfdem
✅ Preview: Canceled

@vercel
Copy link

vercel bot commented Dec 28, 2021

@MarvelSQ is attempting to deploy a commit to the rsuite Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 25dba30:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #2261 (25dba30) into main (9bfbbcc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2261   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files         274      274           
  Lines        8588     8588           
  Branches     2383     2383           
=======================================
  Hits         7358     7358           
  Misses        664      664           
  Partials      566      566           
Flag Coverage Δ
ChromeCi 85.65% <100.00%> (ø)
Firefox 85.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SelectPicker/SelectPicker.tsx 90.90% <ø> (ø)
src/CheckPicker/CheckPicker.tsx 86.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfbbcc...25dba30. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview – rsuite-v4 December 28, 2021 10:08 Inactive
@SevenOutman SevenOutman merged commit 6e3e6c5 into rsuite:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants