Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MultiCascader): fix not rendering the count of selected values #2289

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Jan 7, 2022

before

image

after

image

@vercel
Copy link

vercel bot commented Jan 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/Heb2b4imJvUJowYjJ7WjpoS8d9aj
✅ Preview: Canceled

rsuite-nextjs – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-nextjs/Ayy2bDMh8LQyjEMeS781Q6LREuue
✅ Preview: https://rsuite-nextjs-git-fix-multicascader-countable-rsuite.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a9a6621:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #2289 (a9a6621) into main (be9c756) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2289   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files         274      274           
  Lines        8576     8576           
  Branches     2379     2379           
=======================================
  Hits         7349     7349           
  Misses        666      666           
  Partials      561      561           
Flag Coverage Δ
ChromeCi 85.66% <ø> (ø)
Firefox 85.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/MultiCascader/MultiCascader.tsx 77.24% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9c756...a9a6621. Read the comment docs.

@SevenOutman SevenOutman merged commit 324e90c into main Jan 10, 2022
@SevenOutman SevenOutman deleted the fix/MultiCascader-countable branch January 10, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants