Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useTimeout): fix callback not being called after timeout #2349

Merged
merged 1 commit into from Feb 17, 2022

Conversation

simonguo
Copy link
Member

fix #2314

@vercel
Copy link

vercel bot commented Feb 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/D12s8TiFZ56jQq936uzor4RR3xPt
✅ Preview: Canceled

rsuite-nextjs – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-nextjs/ATteFdhPcN5yQw5DCjZxmWPKWJkB
✅ Preview: https://rsuite-nextjs-git-fix-usetimeout-rsuite.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 93385a3:

Sandbox Source
rsuite-tp-ci Configuration
stupefied-dew-6ext8 Issue #2314

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #2349 (93385a3) into main (d5368cd) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2349      +/-   ##
==========================================
- Coverage   85.69%   85.67%   -0.02%     
==========================================
  Files         274      274              
  Lines        8617     8622       +5     
  Branches     2404     2405       +1     
==========================================
+ Hits         7384     7387       +3     
  Misses        656      656              
- Partials      577      579       +2     
Flag Coverage Δ
ChromeCi 85.65% <87.50%> (-0.02%) ⬇️
Firefox 85.65% <87.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/useTimeout.ts 93.75% <87.50%> (+2.84%) ⬆️
src/Carousel/Carousel.tsx 90.90% <0.00%> (-3.64%) ⬇️
src/IconButton/IconButton.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5368cd...93385a3. Read the comment docs.

@simonguo simonguo merged commit e82a12a into main Feb 17, 2022
@simonguo simonguo deleted the fix/useTimeout branch February 17, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Toaster] 在定时时间范围之内多次执行,所有的应该过时消失的 Message 都不消失。
1 participant