Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sidenav): remove underline from focused sidenav item #2387

Merged
merged 1 commit into from Mar 10, 2022

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Mar 8, 2022

Before
image

After
image

@vercel
Copy link

vercel bot commented Mar 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/3chttoRcWFc2q9CtvhJXv753jEUo
✅ Preview: Canceled

rsuite-nextjs – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-nextjs/E8xZZx9sFJHN8SQRiGUDwsePW6x3
✅ Preview: https://rsuite-nextjs-git-fix-sidenav-item-focus-underline-rsuite.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d1a5f1:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #2387 (9d1a5f1) into main (3d3bcca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2387   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         274      274           
  Lines        8647     8647           
  Branches     2428     2428           
=======================================
  Hits         7399     7399           
  Misses        659      659           
  Partials      589      589           
Flag Coverage Δ
ChromeCi 85.54% <ø> (ø)
Firefox 85.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3bcca...9d1a5f1. Read the comment docs.

@SevenOutman SevenOutman merged commit a22f569 into main Mar 10, 2022
@SevenOutman SevenOutman deleted the fix/Sidenav-item-focus-underline branch March 10, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants