Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(less): expose primary palette variables #2532

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Jun 7, 2022

Primary palette variables (@Hxxx and @Bxxx) were not available in early v5 releases because of the unified stylesheet with dark mode. Now they are available with dark mode specific variables assigned separate names.

Less variable Description
H050 ~ H900 Highlight levels in light color mode
B050 ~ B900 Gray levels in light color mode
H050-dark ~ H900-dark Highlight levels in dark color mode
B050-dark ~ B900-dark Gray levels in dark color mode
H050-high-contrast ~ H900-high-contrast Highlight levels in high-contrast color mode
B050-high-contrast ~ B900-high-contrast Gray levels in high-contrast color mode

@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Jun 7, 2022 at 8:37AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Jun 7, 2022 at 8:37AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f51ca85:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #2532 (f51ca85) into main (5669caf) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2532      +/-   ##
==========================================
+ Coverage   85.28%   85.30%   +0.02%     
==========================================
  Files         293      293              
  Lines        9084     9084              
  Branches     2552     2552              
==========================================
+ Hits         7747     7749       +2     
+ Misses        701      700       -1     
+ Partials      636      635       -1     
Flag Coverage Δ
ChromeCi 85.28% <ø> (ø)
Firefox 85.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/useRootClose.ts 84.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5669caf...f51ca85. Read the comment docs.

@SevenOutman SevenOutman merged commit b1d187d into main Jun 7, 2022
@SevenOutman SevenOutman deleted the feat/palette-less-variables branch June 7, 2022 11:38
myNameIsDu pushed a commit to myNameIsDu/rsuite that referenced this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants