Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorect CellProps type anotation #2975

Closed
GedisG opened this issue Dec 12, 2022 · 1 comment
Closed

Incorect CellProps type anotation #2975

GedisG opened this issue Dec 12, 2022 · 1 comment
Labels
component: Table Stale status: Needs More Info There's no enough information to understand or reproduce the issue topic: TypeScript Issues about TypeScript declarations.

Comments

@GedisG
Copy link

GedisG commented Dec 12, 2022

What version of rsuite are you using?

5.23.2

What version of React are you using?

17.0.2

What version of TypeScript are you using (if any)?

4.8.2

What browser are you using?

Chrome

Describe the Bug

Just upgraded rsuite from version 5.8.1 to 5.23.2, and now typescript has errors with CellProps.

Right now importing CellProps from rsuite types are different from importing CellProps from rsuite-table types. This creates a typescript error because of a dataKey difference in both annotations when using Table.Cell and importing type annotation from rsuite

Expected Behavior

Make both CellProps types same or just remove one of the types and delete the one that is not necessary

To Reproduce

No response
@SevenOutman SevenOutman added topic: TypeScript Issues about TypeScript declarations. component: Table labels Jan 29, 2023
@simonguo
Copy link
Member

I can't reproduce this bug, could you reproduce the bug through codesandbox?

@SevenOutman SevenOutman added the status: Needs More Info There's no enough information to understand or reproduce the issue label Feb 15, 2023
@github-actions github-actions bot added the Stale label Sep 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: Table Stale status: Needs More Info There's no enough information to understand or reproduce the issue topic: TypeScript Issues about TypeScript declarations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonguo @SevenOutman @GedisG