Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker): fix uncontrolled default date on calendar #3045

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

simonguo
Copy link
Member

fix: #3043

https://codesandbox.io/s/dreamy-water-vwvyul

Before

20230131-144953-HD-1.mp4

After

20230131-145104-HD-2.mp4

@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Jan 31, 2023 at 6:53AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Jan 31, 2023 at 6:53AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d846705:

Sandbox Source
rsuite-tp-ci Configuration
winter-frog-qzm1yb PR

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 93.29% // Head: 93.30% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d846705) compared to base (47342c9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3045   +/-   ##
=======================================
  Coverage   93.29%   93.30%           
=======================================
  Files         560      560           
  Lines       20119    20144   +25     
  Branches     2721     2721           
=======================================
+ Hits        18770    18795   +25     
  Misses        702      702           
  Partials      647      647           
Flag Coverage Δ
ChromeCi 93.26% <100.00%> (+<0.01%) ⬆️
Firefox 92.55% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Calendar/useCalendarDate.ts 100.00% <100.00%> (ø)
src/DatePicker/DatePicker.tsx 93.75% <100.00%> (ø)
src/DatePicker/test/DatePickerSpec.tsx 100.00% <100.00%> (ø)
src/Drawer/test/DrawerBodySpec.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SevenOutman SevenOutman merged commit c530b25 into main Feb 1, 2023
@SevenOutman SevenOutman deleted the fix/DatePicker branch February 1, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker calendar panel initial display error
2 participants