Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form.control): shouldResetWithUnmount isn't working #3055

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

myNameIsDu
Copy link
Member

When several components unmount at the same time.

React will call them one by one, and the later ones will overwrite the earlier ones.

@vercel
Copy link

vercel bot commented Feb 3, 2023

@myNameIsDu is attempting to deploy a commit to the rsuite Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b980b39:

Sandbox Source
rsuite-tp-ci Configuration

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 11:15AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
rsuite-v4 ⬜️ Ignored (Inspect) Feb 7, 2023 at 11:15AM (UTC)

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 93.29% // Head: 93.32% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (b980b39) compared to base (9806267).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3055      +/-   ##
==========================================
+ Coverage   93.29%   93.32%   +0.02%     
==========================================
  Files         560      560              
  Lines       20119    20170      +51     
  Branches     2721     2724       +3     
==========================================
+ Hits        18770    18823      +53     
  Misses        702      702              
+ Partials      647      645       -2     
Flag Coverage Δ
ChromeCi 93.28% <100.00%> (+0.02%) ⬆️
Firefox 92.56% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Form/Form.tsx 88.70% <100.00%> (+0.18%) ⬆️
src/FormControl/test/FormControlSpec.tsx 100.00% <100.00%> (ø)
src/Navbar/NavbarDropdown.tsx 84.00% <0.00%> (ø)
src/Navbar/test/NavbarSpec.tsx 100.00% <0.00%> (ø)
src/Calendar/useCalendarDate.ts 100.00% <0.00%> (ø)
src/Drawer/test/DrawerBodySpec.tsx 100.00% <0.00%> (ø)
src/TagInput/test/TagInputSpec.tsx 100.00% <0.00%> (ø)
src/DatePicker/test/DatePickerSpec.tsx 100.00% <0.00%> (ø)
src/InputPicker/InputPicker.tsx 85.92% <0.00%> (+0.10%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

when several components unmount at the same time,
React will call them one by one, and the later ones will overwrite the earlier ones
@SevenOutman SevenOutman merged commit 98c7e1d into rsuite:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants