Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): fix Button content not center-aligned #3087

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Feb 28, 2023

Button content alignment was broken since display is updated to inline-flex in #3067. This affects Buttons with explicitly specified width.

A repro can be found in Sidenav example on docs site https://rsuitejs.com/components/sidenav/#appearance

企业微信截图_40a92946-1758-4601-ac74-304d617283db

@vercel
Copy link

vercel bot commented Feb 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 3:54AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
rsuite-v4 ⬜️ Ignored (Inspect) Feb 28, 2023 at 3:54AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c91931:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Base: 93.34% // Head: 93.34% // No change to project coverage 👍

Coverage data is based on head (0c91931) compared to base (f402583).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3087   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files         561      561           
  Lines       20226    20226           
  Branches     2727     2727           
=======================================
  Hits        18880    18880           
  Misses        701      701           
  Partials      645      645           
Flag Coverage Δ
ChromeCi 93.30% <ø> (ø)
Firefox 92.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SevenOutman SevenOutman merged commit 28ff13b into main Mar 1, 2023
@SevenOutman SevenOutman deleted the fix/Button-text-center branch March 1, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants