Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Carousel): fix index not being reset when children change #3185

Merged
merged 2 commits into from
May 8, 2023

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented May 6, 2023

fix: #3175

@vercel
Copy link

vercel bot commented May 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 7:53am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) May 8, 2023 7:53am

@simonguo simonguo requested a review from SevenOutman May 6, 2023 10:08
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f469c5:

Sandbox Source
rsuite-tp-ci Configuration
focused-farrell-o4gqls Issue #3175

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1a9805a) 93.36% compared to head (4f469c5) 93.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3185   +/-   ##
=======================================
  Coverage   93.36%   93.37%           
=======================================
  Files         563      563           
  Lines       20290    20299    +9     
  Branches     2757     2758    +1     
=======================================
+ Hits        18944    18954   +10     
  Misses        697      697           
+ Partials      649      648    -1     
Flag Coverage Δ
ChromeCi 93.26% <100.00%> (+<0.01%) ⬆️
Firefox 92.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Carousel/Carousel.tsx 91.52% <100.00%> (+0.61%) ⬆️
src/Carousel/test/CarouselSpec.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SevenOutman SevenOutman merged commit 3afb746 into main May 8, 2023
7 checks passed
@SevenOutman SevenOutman deleted the fix/Carousel branch May 8, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants