Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InputPicker): add missing top padding of listbox #3214

Merged
merged 1 commit into from
May 26, 2023

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented May 25, 2023

Expected

image

Actual (before fix)

image

Fixed

image

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 2:57am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) May 25, 2023 2:57am

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c7e946b:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (3bf07b0) 93.30% compared to head (c7e946b) 93.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3214      +/-   ##
==========================================
- Coverage   93.30%   93.30%   -0.01%     
==========================================
  Files         564      564              
  Lines       20079    20079              
  Branches     2755     2756       +1     
==========================================
- Hits        18735    18734       -1     
  Misses        697      697              
- Partials      647      648       +1     
Flag Coverage Δ
ChromeCi 93.26% <100.00%> (-0.01%) ⬇️
Firefox 92.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/InputPicker/InputPicker.tsx 87.40% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SevenOutman SevenOutman requested a review from simonguo May 25, 2023 03:26
@SevenOutman SevenOutman merged commit f6df23c into main May 26, 2023
13 of 14 checks passed
@SevenOutman SevenOutman deleted the fix/InputPicker-listbox-padding-top branch May 26, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants