Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TagInput): fix tag create during text composing #3244

Merged
merged 3 commits into from
Jun 20, 2023
Merged

fix(TagInput): fix tag create during text composing #3244

merged 3 commits into from
Jun 20, 2023

Conversation

MarvelSQ
Copy link
Member

@MarvelSQ MarvelSQ commented Jun 14, 2023

CHANGES

ignore key press while composing.

ISSUE

close #3243

@vercel
Copy link

vercel bot commented Jun 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 10:08am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Jun 14, 2023 10:08am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 14, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2dd5f3e:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (672bdc5) 93.34% compared to head (2dd5f3e) 93.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3244   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files         568      568           
  Lines       20204    20218   +14     
  Branches     2766     2767    +1     
=======================================
+ Hits        18859    18873   +14     
  Misses        697      697           
  Partials      648      648           
Flag Coverage Δ
ChromeCi 93.30% <100.00%> (+<0.01%) ⬆️
Firefox 92.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/InputPicker/InputPicker.tsx 87.50% <100.00%> (+0.09%) ⬆️
src/TagInput/test/TagInputSpec.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simonguo simonguo merged commit 86451d7 into main Jun 20, 2023
14 checks passed
@simonguo simonguo deleted the fix/3243 branch June 20, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TagInput: Multiple tags created when using Chinese input method
2 participants