Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Picker): change color of caret on option group title #3323

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Aug 8, 2023

The caret color should be @B600 per design, but was implemented as @B800.

Design

image

Before fix

image

After fix

image

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 3:27am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2023 3:27am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 94bce73:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (966c01c) 93.38% compared to head (94bce73) 93.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3323      +/-   ##
==========================================
- Coverage   93.38%   93.38%   -0.01%     
==========================================
  Files         569      569              
  Lines       20255    20255              
  Branches     2771     2771              
==========================================
- Hits        18916    18915       -1     
  Misses        688      688              
- Partials      651      652       +1     
Flag Coverage Δ
ChromeCi 93.34% <ø> (-0.01%) ⬇️
Firefox 92.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeightonYao
Copy link

OK

@SevenOutman SevenOutman merged commit 0d7be85 into main Aug 11, 2023
14 of 15 checks passed
@SevenOutman SevenOutman deleted the fix/SelectPicker-group-caret-color branch August 11, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants