Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Calendar): add cellClassName prop #3336

Merged
merged 3 commits into from
Aug 17, 2023
Merged

feat(Calendar): add cellClassName prop #3336

merged 3 commits into from
Aug 17, 2023

Conversation

hyoban
Copy link
Contributor

@hyoban hyoban commented Aug 15, 2023

fix #3333

@vercel
Copy link

vercel bot commented Aug 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 4:46am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Aug 17, 2023 4:46am

@vercel
Copy link

vercel bot commented Aug 15, 2023

@hyoban is attempting to deploy a commit to the rsuite Team on Vercel.

A member of the Team first needs to authorize it.

@hyoban hyoban changed the title feat(calendar): add cellClassName prop feat(Calendar): add cellClassName prop Aug 15, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c9a08e:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (035d287) 93.38% compared to head (0f0257f) 93.38%.

❗ Current head 0f0257f differs from pull request most recent head 1c9a08e. Consider uploading reports for the commit 1c9a08e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3336      +/-   ##
==========================================
- Coverage   93.38%   93.38%   -0.01%     
==========================================
  Files         569      569              
  Lines       20265    20259       -6     
  Branches     2771     2772       +1     
==========================================
- Hits        18924    18918       -6     
- Misses        691      692       +1     
+ Partials      650      649       -1     
Flag Coverage Δ
ChromeCi 93.34% <100.00%> (-0.01%) ⬇️
Firefox 92.66% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Calendar/Calendar.tsx 89.65% <ø> (-2.94%) ⬇️
src/Calendar/CalendarContainer.tsx 100.00% <ø> (ø)
src/Calendar/TableRow.tsx 91.52% <100.00%> (ø)
src/Calendar/test/CalendarTableRowSpec.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SevenOutman SevenOutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyoban Thanks for contributing this edit! Such thorough implementation, tests and docs!

Please do me a favor to keep the props table in alphabetic order then we're ready to go :)
(You can make Prettier do this by applying prettier-sort-markdown-table annotation like how it's done in #3203)

@hyoban
Copy link
Contributor Author

hyoban commented Aug 16, 2023

@SevenOutman done!

Copy link
Member

@SevenOutman SevenOutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm requesting a final check from @simonguo as this PR involves design of new APIs.

@SevenOutman
Copy link
Member

@hyoban There's some conflicts when I'm going to merge this PR. Would you please resolve them?

@hyoban
Copy link
Contributor Author

hyoban commented Aug 17, 2023

@SevenOutman should be ok now

@SevenOutman SevenOutman merged commit cb7c2ae into rsuite:main Aug 17, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom background color of Calendar cells
3 participants