Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TagPicker,TagInput): add support for onTagRemove #3413

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

simonguo
Copy link
Member

/** Callback fired when a tag is removed. */
onTagRemove?: (tag: string, event: React.MouseEvent) => void;

#3410

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Oct 23, 2023 11:48am
1 Ignored Deployment
Name Status Preview Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Oct 23, 2023 11:48am

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2a85907:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19b9e32) 93.40% compared to head (2a85907) 93.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3413   +/-   ##
=======================================
  Coverage   93.40%   93.40%           
=======================================
  Files         569      569           
  Lines       20313    20327   +14     
  Branches     2780     2780           
=======================================
+ Hits        18973    18987   +14     
  Misses        689      689           
  Partials      651      651           
Flag Coverage Δ
ChromeCi 93.36% <100.00%> (+<0.01%) ⬆️
Firefox 92.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/InputPicker/InputPicker.tsx 87.59% <100.00%> (+0.04%) ⬆️
src/TagInput/index.tsx 100.00% <100.00%> (ø)
src/TagInput/test/TagInputSpec.tsx 100.00% <100.00%> (ø)
src/TagPicker/index.tsx 100.00% <100.00%> (ø)
src/TagPicker/test/TagPickerSpec.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo merged commit 96f96ab into main Oct 27, 2023
15 checks passed
@simonguo simonguo deleted the feat/onTagRemove branch October 27, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant