Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve accessibility of all pickers #3558

Merged
merged 10 commits into from
Jan 16, 2024
Merged

feat: improve accessibility of all pickers #3558

merged 10 commits into from
Jan 16, 2024

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Jan 13, 2024

  • Generates a unique id for the popup when id is not set, and associates it with the combobox's aria-controls property.
  • The role of Cascader and MuiltCascader popup is changed to tree.
  • Add a combobox role for AutoComplete.
  • Add the aria-activedescendant attribute to indicate the ID of the focused option.
  • Add aria-multiselectable=true when listbox or tree is multi-selected
  • fix the conflict between treeitem role and option role in CheckTreePicker.
  • fix keyboard interaction options not working on AutoComplete.
  • Update on accessibility guidelines

Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 8:49am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 8:49am

Copy link

codesandbox-ci bot commented Jan 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2605df2:

Sandbox Source
rsuite-tp-ci Configuration

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (0fb292b) 93.43% compared to head (2605df2) 93.44%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Picker/hooks/useFocusItemValue.ts 78.94% 6 Missing and 18 partials ⚠️
src/Cascader/TreeView.tsx 74.24% 8 Missing and 9 partials ⚠️
src/Picker/Listbox.tsx 80.48% 9 Missing and 7 partials ⚠️
src/TreePicker/TreeNode.tsx 78.78% 3 Missing and 4 partials ⚠️
src/CheckTreePicker/CheckTreeNode.tsx 76.47% 2 Missing and 2 partials ⚠️
src/MultiCascader/TreeView.tsx 87.87% 1 Missing and 3 partials ⚠️
src/InputPicker/InputPicker.tsx 81.25% 2 Missing and 1 partial ⚠️
src/Picker/hooks/useToggleKeyDownEvent.ts 91.66% 2 Missing and 1 partial ⚠️
src/CheckTreePicker/CheckTreePicker.tsx 83.33% 0 Missing and 1 partial ⚠️
src/Picker/ListCheckItem.tsx 90.90% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3558      +/-   ##
==========================================
+ Coverage   93.43%   93.44%   +0.01%     
==========================================
  Files         593      601       +8     
  Lines       21331    21303      -28     
  Branches     2959     2957       -2     
==========================================
- Hits        19931    19907      -24     
- Misses        715      718       +3     
+ Partials      685      678       -7     
Flag Coverage Δ
ChromeCi 93.39% <91.68%> (+0.01%) ⬆️
Firefox 92.85% <91.68%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo merged commit 8ad3cfd into main Jan 16, 2024
14 of 15 checks passed
@simonguo simonguo deleted the aria/pickers branch January 16, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant