Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for CascadeTree and MultiCascadeTree #3563

Merged
merged 19 commits into from
Mar 19, 2024
Merged

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Jan 17, 2024

https://rsuite-nextjs-git-feat-cascade-tree-rsuite.vercel.app/components/cascade-tree/
https://rsuite-nextjs-git-feat-cascade-tree-rsuite.vercel.app/components/multi-cascade-tree/

  1. Add CascadeTree and MultiCascadeTree component to replace <Cascader inline> and <MultiCascader inline>

Before:

<Cascader inline />;
<MultiCascader inline />;

After:

<CascadeTree />;
<MultiCascadeTree />;
  1. In order to make the attribute naming more semantically unified, we renamed some of the attributes of Cascader and MultiCascader, as follows:
  • rendeMenu -> renderColumn
  • renderMenuItem -> renderTreeNode
  • menuClassName -> popupClassName
  • menuStyle -> popupStyle
  • menuWidth -> columnWidth
  • menuHeight -> columnHeight
  • inline deprecated

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 6:46am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 6:46am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 6:46am

Copy link

codesandbox-ci bot commented Jan 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: Patch coverage is 92.51701% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 93.75%. Comparing base (a9e14ee) to head (f91b469).
Report is 5 commits behind head on main.

Files Patch % Lines
src/MultiCascadeTree/hooks/useCascadeValue.ts 73.33% 12 Missing and 8 partials ⚠️
src/MultiCascadeTree/utils.ts 85.00% 4 Missing and 5 partials ⚠️
src/MultiCascader/MultiCascader.tsx 81.63% 8 Missing and 1 partial ⚠️
src/MultiCascadeTree/SearchView.tsx 76.00% 4 Missing and 2 partials ⚠️
src/Cascader/useActive.ts 76.47% 2 Missing and 2 partials ⚠️
src/CascadeTree/hooks/useSelect.ts 88.00% 2 Missing and 1 partial ⚠️
src/MultiCascadeTree/hooks/useSelect.ts 90.32% 2 Missing and 1 partial ⚠️
src/CascadeTree/SearchView.tsx 92.00% 1 Missing and 1 partial ⚠️
src/CascadeTree/TreeView.tsx 91.30% 1 Missing and 1 partial ⚠️
src/CascadeTree/hooks/useSearch.ts 92.00% 1 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3563      +/-   ##
==========================================
+ Coverage   93.58%   93.75%   +0.17%     
==========================================
  Files         621      637      +16     
  Lines       21980    22318     +338     
  Branches     3016     3052      +36     
==========================================
+ Hits        20569    20925     +356     
+ Misses        730      713      -17     
+ Partials      681      680       -1     
Flag Coverage Δ
ChromeCi 93.71% <92.51%> (+0.17%) ⬆️
Firefox 93.13% <90.81%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo changed the title feat(CascadeTree): add support for CascadeTree feat: add support for CascadeTree and MultiCascadeTree Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant