Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DateRangePicker): fix error state when value is empty array #3631

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

simonguo
Copy link
Member

fix: #3626

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 8:01am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 8:01am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 8:01am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33159b6) 93.58% compared to head (36c0bb3) 93.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3631      +/-   ##
==========================================
- Coverage   93.58%   93.58%   -0.01%     
==========================================
  Files         612      612              
  Lines       21722    21732      +10     
  Branches     2987     2988       +1     
==========================================
+ Hits        20328    20337       +9     
  Misses        722      722              
- Partials      672      673       +1     
Flag Coverage Δ
ChromeCi 93.53% <100.00%> (-0.01%) ⬇️
Firefox 92.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo merged commit f8778f5 into main Feb 22, 2024
15 of 16 checks passed
@simonguo simonguo deleted the fix/DateRangePicker-error-value branch February 22, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateRangePicker is in error state without any values by default when used in Form
1 participant