Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pagination): fix SelectPicker rendering misalignment #3643

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Feb 23, 2024

fix: #3050

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 2:54am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 2:54am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 2:54am

Copy link

codesandbox-ci bot commented Feb 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 88.54962% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 93.58%. Comparing base (438d43a) to head (dff547c).
Report is 1 commits behind head on main.

Files Patch % Lines
src/Pagination/PaginationGroup.tsx 35.00% 12 Missing and 1 partial ⚠️
src/Pagination/PaginationButton.tsx 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3643      +/-   ##
==========================================
- Coverage   93.58%   93.58%   -0.01%     
==========================================
  Files         619      620       +1     
  Lines       21943    21910      -33     
  Branches     3010     3005       -5     
==========================================
- Hits        20535    20504      -31     
  Misses        728      728              
+ Partials      680      678       -2     
Flag Coverage Δ
ChromeCi 93.53% <88.54%> (-0.01%) ⬇️
Firefox 92.99% <88.54%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo changed the title fix(Pagination): fix LimitPicker rendering misalignment fix(Pagination): fix SelectPicker rendering misalignment Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add container prop to pagination
1 participant