Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TagGroup): fix css entry with nested children #3663

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

obdulia-losantos
Copy link
Contributor

I'm not a css expert but in my project when the rollup task tries to minify the styles it displays this error.

warnings when minifying css:
▲ [WARNING] Unexpected "{" [css-syntax-error]

 .rs-tag-group>{margin-left:10px;margin-top:10px}

With the change the resultant css file (lib/TagGroup/styles/index.css) is:

/* stylelint-disable */
*[class*='rs-'] {
 -webkit-box-sizing: border-box;
         box-sizing: border-box;
}
*[class*='rs-']::before,
*[class*='rs-']::after {
 -webkit-box-sizing: border-box;
         box-sizing: border-box;
}
.rs-tag-group {
 margin: -10px 0 0 -10px;
}
.rs-tag-group > .rs-tag {
 margin-top: 10px;
 margin-left: 10px;
}

/*# sourceMappingURL=index.css.map */

While now is:

/* stylelint-disable */
*[class*='rs-'] {
  -webkit-box-sizing: border-box;
          box-sizing: border-box;
}
*[class*='rs-']::before,
*[class*='rs-']::after {
  -webkit-box-sizing: border-box;
          box-sizing: border-box;
}
.rs-tag-group {
  margin: -10px 0 0 -10px;
}
.rs-tag-group >  {
  margin-top: 10px;
  margin-left: 10px;
}

/*# sourceMappingURL=index.css.map */

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 2:22am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 2:22am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 2:22am

Copy link

vercel bot commented Mar 11, 2024

@obdulia-losantos is attempting to deploy a commit to the rsuite Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (83052ed) to head (87937d6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3663   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files         621      621           
  Lines       21950    21950           
  Branches     3014     3014           
=======================================
  Hits        20542    20542           
  Misses        729      729           
  Partials      679      679           
Flag Coverage Δ
ChromeCi 93.53% <ø> (ø)
Firefox 92.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@simonguo simonguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonguo simonguo merged commit fc59018 into rsuite:main Mar 14, 2024
16 checks passed
@obdulia-losantos obdulia-losantos deleted the fix-tag-group-less branch March 14, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants