Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Loader): set correct ARIA properties for Loader #3691

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

simonguo
Copy link
Member

No description provided.

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 7:03am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 7:03am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 7:03am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (524fc7a) to head (85f1e2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3691   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files         637      637           
  Lines       22318    22323    +5     
  Branches     3052     3053    +1     
=======================================
+ Hits        20925    20930    +5     
  Misses        713      713           
  Partials      680      680           
Flag Coverage Δ
ChromeCi 93.71% <100.00%> (+<0.01%) ⬆️
Firefox 93.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo merged commit 92505e2 into main Mar 22, 2024
16 checks passed
@simonguo simonguo deleted the fix/loader-aria branch March 22, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant