Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some css classes interfere with other projects #825

Closed
iSplasher opened this issue Jan 17, 2020 · 3 comments
Closed

Some css classes interfere with other projects #825

iSplasher opened this issue Jan 17, 2020 · 3 comments

Comments

@iSplasher
Copy link

Versions

package version
react 16.12.0
rsuite 4.2.0

What is the current behavior?

Hello, thanks for this fantastic library.
Some classes have generic names like .hidden, which interfere with other projects such as tailwindcss. The markup for .hidden is

.hidden {
    display: none !important;
}

So it's not even possible to override it.

What is the expected behavior?

It would be great if every class names were prefixed with rs- just like most classes.
.hidden -> .@{ns}hidden

What are the steps to reproduce?

Try and use media queries with the .hidden class:

@media only screen and (max-width: 600px) {
  .hidden {
    display: block;
  }
}

It won't work.

Any additional comments? (optional)

@iSplasher
Copy link
Author

Another benefit is when you use postcss-purgecss.
You can easily whitelist rsuite rules with /^rs-/.

@hiyangguo
Copy link
Member

The same with #582

@SevenOutman
Copy link
Member

Closing due to duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants