Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS improvement #1738

Open
ghost opened this issue Aug 23, 2017 · 7 comments
Open

TLS improvement #1738

ghost opened this issue Aug 23, 2017 · 7 comments

Comments

@ghost
Copy link

ghost commented Aug 23, 2017

This is a meta issue tracker used for referencing information and all existing issues related to TLS.

Articles

Issues

Done

@rgerhards
Copy link
Member

@PascalWithopf can you please update what is still open?

@skupkosk
Copy link

Any due date for TLS rewrite?
You might have a look on syslog-ng sources.

@rgerhards rgerhards added this to To Do in TLS improvements incl. openssl driver via automation Jan 19, 2018
@rgerhards rgerhards assigned alorbach and unassigned ghost May 15, 2018
@rgerhards
Copy link
Member

TLS rewrite is available with at least 8.37.0

@rgerhards
Copy link
Member

@alorbach is this solved?

@alorbach
Copy link
Member

alorbach commented Sep 5, 2018

All issues are closed / Fixed except for these ones:

Issues related to GNUTLS not reproduceable or need additional help:
rsyslog hangs when TLS close_notify goes unanswered #1231
rsyslog doesn't respond to TLS close_notify #1503

Enhancements:
Verify Hostname when in Auth Name Mode #436
CA file needed when both sender and receiver skip authentication #1068

@JPvRiel
Copy link

JPvRiel commented Aug 20, 2019

Just to add, imrelp isn't allowing TLS optional client certificate 'anon' mode.

This was raised with #435, but that issue was a large list with many other things improved (thanks!). So #3838 added to revisit it.

@JPvRiel
Copy link

JPvRiel commented Sep 1, 2019

I'd like to propose that more robust client authentication options could be provided:

  1. If the CN or a SAN of client cert matches the hostname in the message, have a property, e.g. hostname_verified set as true (effectively allows closing Add Option to Verify Hostname in Syslog Message Against the TLS Client Certficate's CN when in Auth Name Mode #436).
  2. Populate client properties which client certs are provided such as host_authentication_fingerprint and host_authentication_subject from properties in the client cert.

For the openssl implementation, this should be possible via calling the SSL_get_peer_certificate() if/when a client cert was received and verified by allowed CAs.

This has been suggested in several related open issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants