Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom generator class discovery in load_generators method #138

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

rszamszur
Copy link
Member

@rszamszur rszamszur commented Aug 22, 2022

Checklist:

  • Added tests for changed code where applicable.
  • Documentation reflects the changes where applicable.
  • Updated the CHANGELOG.md file with your changes.
  • My PR is ready to review.

Resolves: #137

Description of the changes being introduced by the pull request:

@rszamszur rszamszur added the enhancement New feature or request label Aug 22, 2022
@rszamszur rszamszur self-assigned this Aug 22, 2022
@github-actions
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #138 (00e81af) into master (4c93d8e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #138   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines          801       810    +9     
=========================================
+ Hits           801       810    +9     
Impacted Files Coverage Δ
fastapi_mvc/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/borg.py 100.00% <100.00%> (ø)
fastapi_mvc/commands/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/generators/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/generators/controller/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/generators/generator/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/generators/project/__init__.py 100.00% <100.00%> (ø)
...okiecutter.package_name}}/app/controllers/ready.py 100.00% <100.00%> (ø)
...}/{{cookiecutter.package_name}}/config/__init__.py 100.00% <100.00%> (ø)
fastapi_mvc/parsers/__init__.py 100.00% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rszamszur rszamszur merged commit 41c7777 into master Aug 23, 2022
@rszamszur rszamszur deleted the improve_generators_discovery branch August 23, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve custom generator class discovery in load_generators method
2 participants