Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rt_usb_9axisimu_driver dependency to package.xml #21

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

ShotaAk
Copy link
Contributor

@ShotaAk ShotaAk commented Oct 13, 2020

What does this implement/fix?

#19 の対応です。package.xmlの依存関係にrt_usb_9axisimu_driverを追加し、ビルドエラーを解決します。

依存関係の都合上、rt_usb_9axisimu_driverのインストール前にraspimouse_ros2_examplesをビルドすると失敗することがわかりました。

また、#20 のコメントより、package.xmlrt_usb_9axisimu_driverを追加することで解決することがわかりました。

Does this close any currently open issues?

直接クローズはしませんが、#19 が関連します

How has this been tested?

Ubuntu18.04 & ROS Dashingでビルドが通ることを確認しました。

Checklists

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@ShotaAk ShotaAk added the Type: Documentation Documentation only changes label Oct 13, 2020
@ShotaAk ShotaAk requested a review from Tiryoh October 13, 2020 02:54
@Tiryoh Tiryoh added Type: Bug Bug or Bug fixes and removed Type: Documentation Documentation only changes labels Oct 13, 2020
@Tiryoh
Copy link
Contributor

Tiryoh commented Oct 13, 2020

手元でビルド時に失敗しないことを確認しました。

@Tiryoh Tiryoh merged commit 2dba3eb into master Oct 13, 2020
@Tiryoh Tiryoh deleted the fix_package_xml_for_#19 branch October 13, 2020 05:21
@Tiryoh Tiryoh restored the fix_package_xml_for_#19 branch October 13, 2020 05:21
@Tiryoh Tiryoh deleted the fix_package_xml_for_#19 branch October 13, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants