Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to support ROS Foxy #26

Merged
merged 3 commits into from May 13, 2021
Merged

Update CI to support ROS Foxy #26

merged 3 commits into from May 13, 2021

Conversation

ShotaAk
Copy link
Contributor

@ShotaAk ShotaAk commented Apr 27, 2021

What does this implement/fix?

ROS 2 Foxy 対応に向けてCIを更新します。

また、CIのLintチェックを通すため、ソースコードを修正します。
ソースコードはament_uncrustify --reformatコマンドで自動修正しています。

Does this close any currently open issues?

いいえ

How has this been tested?

CIが通ることを確認しています。
実機テストはしていません。

Any other comments?

ROS 2 Foxyでの実機テストに伴う修正は別PRで行います。
(Dashingにもマージすべき修正点があるため)

Checklists

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@ShotaAk ShotaAk changed the title Support ROS 2 Foxy Update CI to support ROS Foxy Apr 27, 2021
@ShotaAk ShotaAk added the Type: Maintenance Repository Maintenance label Apr 27, 2021
@ShotaAk ShotaAk marked this pull request as ready for review April 27, 2021 08:05
@Tiryoh Tiryoh self-assigned this May 6, 2021
@Tiryoh Tiryoh self-requested a review May 6, 2021 23:49
Copy link
Contributor

@Tiryoh Tiryoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tiryoh Tiryoh merged commit f0fce04 into master May 13, 2021
@Tiryoh Tiryoh deleted the support_foxy branch May 13, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Repository Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants