Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update map command #38

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Update map command #38

merged 3 commits into from
Dec 10, 2021

Conversation

shu-13
Copy link
Contributor

@shu-13 shu-13 commented Dec 8, 2021

What does this implement/fix?

地図を保存するコマンドが更新されていたので、READMEに書かれているコマンドも更新しました。

Does this close any currently open issues?

#37

How has this been tested?

使用した機材はこちら。ロボットもPCもUbuntu 20.04とROS 2 Foxyを使用しています。

  • Raspberry Pi Mouse V3
    • Raspberry Pi 4 Model B

SLAMを実行後、以下のコマンドを実行して地図を保存

ros2 run nav2_map_server map_saver_cli -f ~/maps/mymap

Any other comments?

Checklists

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@shu-13 shu-13 requested a review from ShotaAk December 8, 2021 08:55
@shu-13 shu-13 self-assigned this Dec 8, 2021
@shu-13 shu-13 added the Type: Documentation Documentation only changes label Dec 8, 2021
@Tiryoh Tiryoh linked an issue Dec 8, 2021 that may be closed by this pull request
@ShotaAk
Copy link
Contributor

ShotaAk commented Dec 10, 2021

私の環境ではタイムアウトが発生してしまいました。

[WARN] [1639112687.542261078] [map_saver]: Free threshold unspecified. Setting it to default value: 0.250000
[WARN] [1639112687.542275372] [map_saver]: Occupied threshold unspecified. Setting it to default value: 0.650000
[ERROR] [1639112689.545467507] [map_saver]: Failed to save the map: timeout
[INFO] [1639112689.545515695] [map_saver]: Destroying

タイムアウト時間を変更するパラメータを追記お願いします。(suggestします)

参考:https://answers.ros.org/question/379565/timeout-error-while-saving-map/?answer=392248#post-id-392248

Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROS Foxyにて動作確認できました。
パラメータの追記お願い致します。

README.en.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
shu-13 and others added 2 commits December 10, 2021 14:30
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit f16aef6 into master Dec 10, 2021
@ShotaAk ShotaAk deleted the feature/update-readme-slam branch December 10, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation only changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

地図の保存コマンド
2 participants