Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rplidar_a1_launch.py because rplidar.launch.py does not exist. #8

Merged
merged 2 commits into from Jan 15, 2024

Conversation

ShotaAk
Copy link
Contributor

@ShotaAk ShotaAk commented Jan 15, 2024

What does this implement/fix?

rplidarを起動するためのlaunchファイル名を変更します。

rplidar_rosのソースリポジトリ変更に伴い、rplidar.launch.pyは廃止されました。

参考:ros/rosdistro#37679

変更後のlaunchファイル:https://github.com/Slamtec/rplidar_ros/blob/70d91854e7ae167709c1f1baa4362b1e9847b548/launch/rplidar_a1_launch.py

変更前のlaunchファイル:https://github.com/allenh1/rplidar_ros/blob/6fc037db67e234ad7a4272cc2331afeb92ed7200/launch/rplidar.launch.py

Does this close any currently open issues?

いいえ

How has this been tested?

実機で、SLAMとNavigationが動作することを確認しました。

Checklists

@ShotaAk ShotaAk added the Type: Bug Bug or Bug fixes label Jan 15, 2024
@shu-13
Copy link
Contributor

shu-13 commented Jan 15, 2024

変更内容については、特に問題ないと思われます。
READMEの更新をお願いします。ここの部分を消去するだけで良い気がしますっ。
https://github.com/rt-net/raspimouse_slam_navigation_ros2/tree/fix_rplidar_launch_file?tab=readme-ov-file#notes

@ShotaAk ShotaAk merged commit f9966f2 into main Jan 15, 2024
@ShotaAk ShotaAk deleted the fix_rplidar_launch_file branch January 15, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants