Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "binary output mode only" description from README #23

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Remove "binary output mode only" description from README #23

merged 1 commit into from
Jul 21, 2020

Conversation

Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented Jul 16, 2020 •
edited
Loading

What does this implement/fix?

#18, #19, #22, #24 にてバイナリ出力モードとASCII出力モードに対応したので、READMEから「バイナリ出力モードにする必要がある」旨の記述を削除します。

Does this close any currently open issues?

しません。

How has this been tested?

ドキュメントの変更のみです。

Any other comments?

Checklists

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@Tiryoh Tiryoh added the Type: Documentation Documentation only changes label Jul 21, 2020
@Tiryoh Tiryoh requested a review from ShotaAk July 21, 2020 09:33
@Tiryoh Tiryoh added this to the Release 1.0.0 milestone Jul 21, 2020
@Tiryoh Tiryoh marked this pull request as ready for review July 21, 2020 09:33
ShotaAk
ShotaAk approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit 9233f28 into master Jul 21, 2020
@ShotaAk ShotaAk deleted the docs/update-data-format branch July 21, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShotaAk ShotaAk ShotaAk approved these changes

Assignees
No one assigned
Labels
Type: Documentation Documentation only changes
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tiryoh @ShotaAk