undefined is not an object #220

apetrichkovich · 2017-09-24T13:04:57Z

Hi.
I've done npm install react-native-contacts and
react-native link react-native-contacts
Scanning 760 folders for symlinks in /home/alexander/projects/AwesomeProject/node_modules (11ms)

Here is my code:

import React from 'react';
import { StyleSheet, Text, View, Button } from 'react-native';
import { Font } from 'expo';
import Contacts from 'react-native-contacts';
export default class App extends React.Component {
  state = {
    fontLoaded: false
  };
  async componentDidMount() {
    await Font.loadAsync({
      'open-sans-bold': require('./assets/fonts/OpenSans-Bold.ttf')
    });
    this.setState({ fontLoaded: true });
  };
  onPressExport() {
      // var Contacts = require('react-native-contacts');
      // var Contacts = require('./node_modules/react-native-contacts');
      if (window.Contacts || true) {
        if (Contacts.getAll || true) {
            Contacts.getAll((err, contacts) => {
                if (err === 'denied') {
                  // error
                  // error
                  // error
                  console.log('error');
                } else {
                  // contacts returned in []
                  console.log('ok');
                }
            });
        } else {
            console.log('Contacts.getAll == null');
        }
      } else {
          console.log('Contacts == null');
      }
  };
  render() {
    return (
      <View style={styles.container}>
		{
          this.state.fontLoaded ? (
            <Text style={{ fontFamily: 'open-sans-bold', fontSize: 22 }}>
              Привет, мир!
            </Text>
          ) : null
        }
        <Text>Open up App.js to start working on your app!</Text>
        <Text>Changes you make will automatically reload.</Text>
        <Text>Shake your phone to open the developer menu.</Text>
        <Button
          onPress={this.onPressExport}
          title="Export"
          color="#841584"
          accessibilityLabel="Learn more about this purple button"
            />
      </View>
    );
  }
}
const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: '#fff',
    alignItems: 'center',
    justifyContent: 'center',
  },
  baseText: {
    fontFamily: 'open-sans-bold',
	fontSize: 20,
    fontWeight: 'bold'
  }
});

and error:

undefined is not an object (evaluating '_reactNativeContacts2.default.getAll')
onPressExport
    App.js:23:21
touchableHandlePress
    TouchableOpacity.js:129:45
_performSideEffectsForTransition
    Touchable.js:746:34
_receiveSignal
    Touchable.js:664:44
touchableHandleResponderRelease
    Touchable.js:433:24
invokeGuardedCallback
    ReactNativeStack-dev.js:130:19
invokeGuardedCallback
    ReactNativeStack-dev.js:166:43
invokeGuardedCallbackAndCatchFirstError
    ReactNativeStack-dev.js:169:64
executeDispatch
    ReactNativeStack-dev.js:202:128
executeDispatchesInOrder
    ReactNativeStack-dev.js:208:279
executeDispatchesAndRelease
    ReactNativeStack-dev.js:272:58
executeDispatchesAndReleaseTopLevel
    ReactNativeStack-dev.js:276:39
forEachAccumulated
    ReactNativeStack-dev.js:268:37
processEventQueue
    ReactNativeStack-dev.js:340:143
runEventQueueInBatch
    ReactNativeStack-dev.js:637:79
handleTopLevel
    ReactNativeStack-dev.js:642:29
<unknown>
    ReactNativeStack-dev.js:749:51
fiberBatchedUpdates
    ReactNativeStack-dev.js:691:14
performFiberBatchedUpdates
    ReactNativeStack-dev.js:695:31
perform
    ReactNativeStack-dev.js:1382:99
batchedUpdates
    ReactNativeStack-dev.js:2077:139
batchedUpdates$1
    ReactNativeStack-dev.js:1456:61
batchedUpdates
    ReactNativeStack-dev.js:699:31
batchedUpdatesWithControlledComponents
    ReactNativeStack-dev.js:708:30
_receiveRootNodeIDEvent
    ReactNativeStack-dev.js:748:46
receiveTouches
    ReactNativeStack-dev.js:762:60
__callFunction
    MessageQueue.js:266:47
<unknown>
    MessageQueue.js:103:26
__guard
    MessageQueue.js:231:6
callFunctionReturnFlushedQueue
    MessageQueue.js:102:17

The text was updated successfully, but these errors were encountered:

Ajith-Pandian · 2017-10-03T12:23:24Z

@apetrichkovich I think the problem with linking. Did you get the success messages after linking? Since this library is a pure native library. If native codes are not linked, It cannot export "Contacts". That's why you are getting "undefined is not an object" error.

redgetan · 2017-11-12T15:25:10Z

I encountered this problem as well. In my case, i installed the react-native-contacts library as described by @apetrichkovich after the iOS simulator is already running. What I discovered is that react-native link react-native-contacts doesn't actually link the binary in the traditional sense where an executable is built (i.e ld.so ), but rather just specifies it as dependency that needs to be linked in the future . So doing a reload via "cmd+R" wont do anything as it only reloads the javascript file, instead of rebuilding the actual iOS app that'll contain the new native dependency.

So to remove the error, I simply had to quit iOS simulator and restart it again via react-native run-ios to actually re-build/link the executable. And now, the Contacts module becomes available instead of undefined.

wunderkind2k1 · 2017-12-04T18:23:50Z

Dont know wether this is up to date but today I stumbled upon the same problem. I installed the module via "yarn add" instead of npm... and forgot to link. After "react-native link react-native-contacts" and a rebuild via react-native run-ios everything works fine. @apetrichkovich: Maybe this can be closed?

morenoh149 · 2017-12-04T19:11:05Z

Closing to minimize the number of outstanding issues. If you believe the installation instructions should be improved please submit a PR.

sajsanghvi · 2018-01-17T19:32:25Z

I'm still getting this problem even after linking, reinstalling..etc. Any ideas?

wunderkind2k1 · 2018-01-18T20:21:38Z

@sajsanghvi Can you show your code?

sajsanghvi · 2018-01-19T00:02:52Z

@wunderkind2k1

var Contacts = require('react-native-contacts')
Contacts.checkPermission( (err, permission) => {
});

Undefined is not an object "Contacts.checkPermission"

wunderkind2k1 · 2018-01-22T08:29:40Z

this definitely looks like a linking problem. Is your XCode up to date?

HoogsterInc · 2018-01-30T18:39:23Z

I am still having this problem but with Android. I've unlinked, uninstalled, reinstalled, relinked, verified it is linked ( Android module react-native-contacts is already linked ).

rappercn · 2018-02-18T02:12:50Z

I resolved this by adding some code in MainApplication.java

    protected List<ReactPackage> getPackage() {
        return Arrays.<ReactPackage>asList(
                new ReactNativeContacts()
        );
    }

lyw0149 · 2018-02-21T10:47:14Z

Something problem in auto link. after manual link it works well.

In XCode, in the project navigator, right click Libraries ➜ Add Files to [your project's name]
add ./node_modules/react-native-contacts/RCTContacts.xcodeproj
In the XCode project navigator, select your project, select the Build Phases tab and in the Link Binary With Libraries section add libRCTContacts.a

jbienia · 2018-02-21T17:42:55Z

@lyw0149 Thanks a bunch!!! That was extremely helpful. ios would not link for me with the react-native link command. The response was always successful, I restarted, re-built, everything, but the Contacts object remained undefined. Now it works great.

I'm using react-native-contacts: 2.1.1, and "react-native": 0.53.0

devhyunjae · 2018-03-27T03:36:13Z

@lyw0149 Thanks Mate. You saved my time.

@morenoh149 Shouldn't we re-open this issue and fix the link problem?

morenoh149 · 2018-03-27T04:29:51Z

@devhyunjae right, so the solution is to manually link?

devhyunjae · 2018-03-27T04:31:17Z

@morenoh149 yup manual link fixed in my case

deepanjan1 · 2018-04-13T19:56:23Z

I'm still getting this error and I've tried the manual linking and react-native linking. I'm getting the same issue on both iOS and Android. The exact error is:

TypeError: undefined is not an object (evaluating '_reactNativeContacts2.default.getAll')

Below is my code:

import Contacts from 'react-native-contacts';
componentDidMount() {
    let contacts = Contacts.getAll((err, contacts) => {
        if (err === 'denied') {
          return console.log('denied contact book access');
        } else {
          return contacts;
        }
      });

Any idea if it's a bug or something with my code above?

HoogsterInc · 2018-04-13T20:36:34Z

Sorry, this might be too unique for what was happening to me to help - but maybe it can help you.

I've tried manually linking and auto-linking and nothing would work for me. The only library that worked for me linking to android and ios was react native navigation (wix). Every other library I needed for both would only successfully link to ios and always had undefined errors for android. I did two things to solve my problem: I made a new project (fresh init) reinstalling everything and made sure the way I linked react native navigation wasn't causing any trouble. Sadly I did both these at the same time and so I can't tell you if you could just do an init, or double check if another library is causing a problem.

But since doing that all the libraries for android (including this one) linked perfectly and worked, no errors. I lean towards my mismanagement of react native navigation fixing the problem more than the fresh init. If you aren't using a library that affects how android or ios deal with other packages then I would look elsewhere.

To clarify react native nav wasn't causing any problems, I had wrongly inputted how it should handle new libraries coming in (I think, again sadly I tried the init and fixing my implementation at the same time). Also to clarify - whenever I would check if linking was successful it always was, even if the library was undefined when ran. So you can only trust that it is trying to link the code, not that it is actually linked properly if you messed something else up like me.

deepanjan1 · 2018-04-13T23:13:29Z

Hi @HoogsterInc, thanks for this. Can you clarify what you mean by:

..and made sure the way I linked react native navigation wasn't causing any trouble.

I am also using react native navigation, and wondering if maybe I did something there that's messing with Contacts. Thanks!

HoogsterInc · 2018-04-16T21:28:40Z

I've got a terrible memory but let me try to remember what I had. So in step 5 of the docs for installing react native navigation, they say "add the following" so I had kept everything that was already in there and just added that below. But this is all they have in their example doc:
(for some reason my code snippets never stay inside the "insert code" shendig. sorry for any confusion below)

package com.example;

import android.support.annotation.Nullable;

import com.facebook.react.ReactPackage;
import com.reactnativenavigation.NavigationApplication;

import java.util.List;

public class MainApplication extends NavigationApplication {
    @Override
    public boolean isDebug() {
        return BuildConfig.DEBUG;
    }

    @Nullable
    @Override
    public List<ReactPackage> createAdditionalReactPackages() {
        return null;
    }

    @Nullable
    @Override
    public String getJSMainModuleName() {
        return "index";
    }
}

and that is it. Way less code than I had.

If I am remembering correctly I had two places where public List ... was happening. I made the assumption that this was causing confusion in the program of actually loading new packages in. So instead of "adding" that code in, they actually meant replace it (my opinion). Take this with a huge grain of salt because I am a noob, and once it was working I didn't delve any deeper. Also fyi I don't use the @nullable in my code - if you look at the example step #5 again they have this:

protected List<ReactPackage> getPackages() {
         // Add additional packages you require here
         // No need to add RnnPackage and MainReactPackage
         return Arrays.<ReactPackage>asList(
             // eg. new VectorIconsPackage()
         );
     }

So unlike their example project where they return null, I have just the protected List that is returning the other packages. I use the code they have in the installation guide, not the example. I hope that helps!

catherinetcai · 2018-07-06T16:56:49Z

Having the same issue on iOS.

I first linked via react-native link and it said it worked successfully.

Got the same TypeError: undefined is not an object (evaluating '_reactNativeContacts2.default.getAll') that @deepanjan1 is describing.

I tried manually linking on iOS following the instructions and still get the same result.

I'm on 2.2.1 and React Native 0.54.0.

deepanjan1 · 2018-07-06T20:23:37Z

Hi @catherinetcai, for me, because I was using Expo, I had to either use the Expo SDK Contacts API or eject my app. I decided to use the contacts API which works fine, but it can be slow on Android.

catherinetcai · 2018-07-08T02:44:48Z

@deepanjan1 I'm not using Expo and I ran into the issue.

I actually resolved it doing this:

Specifying platform version to 9.0 in my Podfile
Adding s.dependency 'React' in the react-native-contacts .podspec as outlined in Modify 'Header Search Path' for native iOS app to integrate react-nat… #230
pod install

squirtle34 · 2018-10-15T17:14:52Z

In XCode, in the project navigator, right click Libraries ➜ Add Files to [your project's name]
add ./node_modules/react-native-contacts/RCTContacts.xcodeproj
In the XCode project navigator, select your project, select the Build Phases tab and in the Link Binary With Libraries section add libRCTContacts.a

morenoh149 · 2018-10-15T18:06:44Z

closing as now we advise manually linking. If you are using pods and have an issue please open a new issue.

yuvraj24 · 2020-03-23T19:56:15Z

A simple

pod install

did the trick for me here for iOS.

morenoh149 closed this as completed Dec 4, 2017

morenoh149 reopened this Mar 27, 2018

morenoh149 closed this as completed in f4a4a1e Apr 5, 2018

morenoh149 reopened this Jul 8, 2018

wzup mentioned this issue Jul 27, 2018

Cannot read property 'checkPermission' of undefined #316

Closed

morenoh149 closed this as completed Oct 15, 2018

morenoh149 mentioned this issue Jul 14, 2020

null is not an object (evaluating '_reactNativeContacts.default.getAll') in android #539

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

undefined is not an object #220

undefined is not an object #220

apetrichkovich commented Sep 24, 2017 •

edited by morenoh149

Ajith-Pandian commented Oct 3, 2017 •

edited

redgetan commented Nov 12, 2017

wunderkind2k1 commented Dec 4, 2017

morenoh149 commented Dec 4, 2017

sajsanghvi commented Jan 17, 2018

wunderkind2k1 commented Jan 18, 2018

sajsanghvi commented Jan 19, 2018 •

edited by morenoh149

wunderkind2k1 commented Jan 22, 2018

HoogsterInc commented Jan 30, 2018

rappercn commented Feb 18, 2018 •

edited by morenoh149

lyw0149 commented Feb 21, 2018 •

edited

jbienia commented Feb 21, 2018

devhyunjae commented Mar 27, 2018

morenoh149 commented Mar 27, 2018

devhyunjae commented Mar 27, 2018

deepanjan1 commented Apr 13, 2018

HoogsterInc commented Apr 13, 2018

deepanjan1 commented Apr 13, 2018

HoogsterInc commented Apr 16, 2018 •

edited by morenoh149

catherinetcai commented Jul 6, 2018

deepanjan1 commented Jul 6, 2018 •

edited

catherinetcai commented Jul 8, 2018

squirtle34 commented Oct 15, 2018

morenoh149 commented Oct 15, 2018 •

edited

yuvraj24 commented Mar 23, 2020 •

edited

undefined is not an object #220

undefined is not an object #220

Comments

apetrichkovich commented Sep 24, 2017 • edited by morenoh149

Ajith-Pandian commented Oct 3, 2017 • edited

redgetan commented Nov 12, 2017

wunderkind2k1 commented Dec 4, 2017

morenoh149 commented Dec 4, 2017

sajsanghvi commented Jan 17, 2018

wunderkind2k1 commented Jan 18, 2018

sajsanghvi commented Jan 19, 2018 • edited by morenoh149

wunderkind2k1 commented Jan 22, 2018

HoogsterInc commented Jan 30, 2018

rappercn commented Feb 18, 2018 • edited by morenoh149

lyw0149 commented Feb 21, 2018 • edited

jbienia commented Feb 21, 2018

devhyunjae commented Mar 27, 2018

morenoh149 commented Mar 27, 2018

devhyunjae commented Mar 27, 2018

deepanjan1 commented Apr 13, 2018

HoogsterInc commented Apr 13, 2018

deepanjan1 commented Apr 13, 2018

HoogsterInc commented Apr 16, 2018 • edited by morenoh149

catherinetcai commented Jul 6, 2018

deepanjan1 commented Jul 6, 2018 • edited

catherinetcai commented Jul 8, 2018

squirtle34 commented Oct 15, 2018

morenoh149 commented Oct 15, 2018 • edited

yuvraj24 commented Mar 23, 2020 • edited

apetrichkovich commented Sep 24, 2017 •

edited by morenoh149

Ajith-Pandian commented Oct 3, 2017 •

edited

sajsanghvi commented Jan 19, 2018 •

edited by morenoh149

rappercn commented Feb 18, 2018 •

edited by morenoh149

lyw0149 commented Feb 21, 2018 •

edited

HoogsterInc commented Apr 16, 2018 •

edited by morenoh149

deepanjan1 commented Jul 6, 2018 •

edited

morenoh149 commented Oct 15, 2018 •

edited

yuvraj24 commented Mar 23, 2020 •

edited