Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist support #9

Closed
grabbou opened this issue Sep 7, 2015 · 3 comments
Closed

Whitelist support #9

grabbou opened this issue Sep 7, 2015 · 3 comments

Comments

@grabbou
Copy link

grabbou commented Sep 7, 2015

Because sometimes it's easier to write whitelist: ['user'] instead of blacklist: [..list 10 reducers and remember to list new ones as well]... Is this something you've been considering already in the past?

@rt2zz
Copy link
Owner

rt2zz commented Sep 8, 2015

yes, and the code for this would be trivial. My hesitation is that I have yet to see an app that would whitelist more than it would blacklist.

Have you run into this situation? can you explain more about your use case?

@grabbou
Copy link
Author

grabbou commented Sep 8, 2015

Well, in my case, the React app data depends on the user location meaning that even a small change of location requires full data reload (location change loads places, there are pubs in places etc.) hence there's no point in persisting the whole tree since in 99% it will need to reload anyway. The only thing that needs to be serialised at this point is the user profile and its token.

Anyway, it might be just a matter of personal preference, but usually I prefer whitelisting than blacklisting to be explicit about the serialisation.

@rt2zz
Copy link
Owner

rt2zz commented Sep 8, 2015

Makes sense. I just added whitelist to to 0.5.8

Let me know how that goes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants