Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy Face Icons #844

Closed
DamnDramaQueen opened this issue Mar 30, 2017 · 13 comments
Closed

Happy Face Icons #844

DamnDramaQueen opened this issue Mar 30, 2017 · 13 comments

Comments

@DamnDramaQueen
Copy link

Hi,

This is my first timer putting request in, hope is right?

I would like to suggest a new feature be added for the rtmedia lightbox comment box. Currently the comment box only do writing and do not have icons. NOT the emoji I am talking about.

This is an i.e icons would like. birthday cake, smilely, gift, teddy bear. heart, etc etc.

People would like to insert icons along when making comments. Who doesn't?

icons

Please send reply notification or if any update for this feature.

Thanks

@aviral-mittal
Copy link

Hi @robicse11127 can you please share an update on this?

@robicse11127
Copy link
Contributor

@aviral-mittal It is in progress.... Configuring the Emojies on the lightbox comment area.

@aviral-mittal
Copy link

@pavanpatil1 Can you please verify these changes?

@kjnanda
Copy link
Contributor

kjnanda commented Aug 7, 2023

@pavanpatil1 Added emoji support works fine but still there is scope of improvement.

Screenshot 2023-08-07 at 12 00 25 PM
  • emoji icon size is uneven
  • spacing seems not uniform
  • currently, we are only showing limited emoji. The requested emoji icons seems not been added.

@Utsav-Ladani
Copy link
Collaborator

Utsav-Ladani commented Aug 7, 2023

Raised this PR to resolve this issue. Please check and let me know if there is any issue.

CC: @kjnanda, @pavanpatil1

@kjnanda
Copy link
Contributor

kjnanda commented Aug 8, 2023

@Utsav-Ladani We can give scroll event for emoji inside the child panel instead of whole parent window. This does not give good UX.

Please refer to this visual

chrome-capture-2023-7-8


I am yet to test this on Responsive devices. Will the share feedback soon.

I have tested this issue on mobile device and I'm unable to scroll when i open media in light box as shown below visual

RecordIt-B6D54D4F-9B31-401C-B791-C95110F28D2F.2.MP4

CC @pavanpatil1

@Utsav-Ladani
Copy link
Collaborator

I had fixed the UI, but this distortion is coming from emoji-picker.js minified files. I didn't find the source code of this minified file. So we have to create our custom library or use an existing third-party library. I will let you know once it is finalized and the issue is fixed.

@kjnanda
Copy link
Contributor

kjnanda commented Aug 9, 2023

@pavanpatil1 Please refer to comment added by Utsav ☝🏻

@pavanpatil1
Copy link
Collaborator

Hi @kjnanda @Utsav-Ladani, I have checked this and the scroller in the emoji picker seems to be fine now. We can merge the PR in pre-release

Record_2023-08-09-13-09-44.mp4

@kjnanda
Copy link
Contributor

kjnanda commented Aug 9, 2023

@pavanpatil1I've verified this problem on an iPhone, and it's not functioning as intended. The emoji picker is not triggering any scroll events. Do we are still want to progress with know bug?

@Utsav-Ladani
Copy link
Collaborator

I made a few changes yesterday. It is working fine for me on Android. Please check and let me know if something not working.

@kjnanda kjnanda added the fixed label Aug 9, 2023
@kjnanda
Copy link
Contributor

kjnanda commented Aug 9, 2023

Cross verified this issue wrt dev branch and it is working as expected.

@kjnanda
Copy link
Contributor

kjnanda commented Aug 11, 2023

Tested after release and it works as expected.

@kjnanda kjnanda closed this as completed Aug 11, 2023
rtMedia Public Roadmap automation moved this from Q1 2022 – Jan-Mar to Delivered Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants