Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hyperparameters into Instance variables #9

Closed
MateP opened this issue May 27, 2020 · 1 comment · Fixed by #16
Closed

Make hyperparameters into Instance variables #9

MateP opened this issue May 27, 2020 · 1 comment · Fixed by #16

Comments

@MateP
Copy link

MateP commented May 27, 2020

Currently they are global in DDDQN baseline (and possibly others)
@BDonnot
Copy link
Collaborator

BDonnot commented Jun 9, 2020 •
edited
Loading

Hello,

If you use the "dev" package (eg you install it from source) this problem should be solved now. I am updating with new baseline contribution and will update the package right after that :-)

This refactoring has been done for the baselines:

  • SAC
  • DeepQSimple
  • DuelQLeapNet
  • DuelQSimple

@BDonnot BDonnot linked a pull request Jun 16, 2020 that will close this issue
update to version 0.4.1 #16
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update to version 0.4.1 rte-france/l2rpn-baselines
2 participants
@MateP @BDonnot