Skip to content

Latest commit

 

History

History
116 lines (79 loc) · 2.92 KB

cran-comments.md

File metadata and controls

116 lines (79 loc) · 2.92 KB
Raw

Non-hacky solution to vignette problem (18 Jan 2020)

  • fixed vignette build failure

Test environments

  • local OS X install, R 3.6.0
  • ubuntu (on travis-ci), R 3.6.2
  • ubuntu (on travis-ci), R dev r77674

R CMD check results

There were no ERRORs, WARNINGs, or NOTEs.

Resubmission to address Joel Embiid issue in vignette (10 Jan 2020)

  • fixed vignette build failure

Test environments

  • local OS X install, R 3.6.0
  • ubuntu (on travis-ci), R 3.6.2
  • ubuntu (on travis-ci), R dev r77648

R CMD check results

There were no ERRORs, WARNINGs, or NOTEs.

Resubmission to address new table structure on BBR (22 Oct 2019)

  • fixed pulling in the wrong html table in nba-player-per-game-stats.R

Test environments

  • local OS X install, R 3.6.0
  • ubuntu (on travis-ci), R 3.6.1
  • ubuntu (on travis-ci), R dev r77324

Resubmission to address new table structure on BBR (31 Oct 2018)

  • fixed pulling in the wrong html table in nba-player-per-game-stats.R
  • added a dontrun to the advanced statistics example
  • added dontruns to all examples

Test environments

  • local OS X install, R 3.5.1
  • ubuntu (on travis-ci), R 3.5.1
  • ubuntu (on travis-ci), R 3.6.0

R CMD check results

There were no ERRORs, WARNINGs, or NOTEs.

Resubmission to new basketball-reference.com structure (19 Oct 2018)

  • fixed pulling in the wrong html table in nba-per-game-stats-per-36.R

Test environments

  • local OS X install, R 3.5.1
  • ubuntu (on travis-ci), R 3.5.1
  • ubuntu (on travis-ci), R 3.6.0

R CMD check results

There were no ERRORs, WARNINGs, or NOTEs.

Resubmission to address date (16 Jun 2018)

  • fixed Date in nba-standings-by-date.R

Test environments

  • local OS X install, R 3.5.1
  • ubuntu (on travis-ci), R 3.5.0
  • ubuntu (on travis-ci), R 3.6.0

R CMD check results

There were no ERRORs, WARNINGs, or NOTEs.

Resubmission to address date (26 Mar 2018)

  • fixed Date in DESCRIPTION

Test environments

  • local OS X install, R 3.4.3
  • ubuntu (on travis-ci), R 3.4.3

R CMD check results

There were no ERRORs, WARNINGs, or NOTEs.

Resubmission to address janitor issues (22 Mar 2018)

  • addressed the janitor 1.0.0 compliance issues

Test environments

  • local OS X install, R 3.4.3
  • ubuntu (on travis-ci), R 3.4.3

R CMD check results

There were no ERRORs, WARNINGs, or NOTEs.

Resubmission to address archiving of package (25 Nov 2017)

  • updated depends/suggests in description
  • removed the devtools::install_github from the vignette
  • file cleanup

Test environments

  • local OS X install, R 3.4.2
  • ubuntu (on travis-ci), R 3.4.2

R CMD check results

There were no ERRORs, WARNINGs, or NOTEs.

Resubmission

This is a resubmission. In this version I have:

  • Removed the redundant 'in R' in title and description.
  • Converted the DESCRIPTION title to title case.
  • Removed the url in the title.
  • Removed 'this package' from the Description field.
  • Formatted the url in the Description.
  • Changed the license to gpl >= 2